Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Rails version to < 6.1.x #3832

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

kennyadsl
Copy link
Member

Description

This way it doesn't try to use Rails 6.1, which has not yet been released yet and we are not yet compatible with. Not sure why the CI isn't failing on master, I suspect it's for some cached gems.

This is causing all extensions specs to fail and needs to be backported in all versions that are compatible with Rails 6.

This way it doesn't try to use Rails 6.1, which has not
yet been released yet and we are not yet compatible with.
@kennyadsl kennyadsl added type:bug Error, flaw or fault Needs Backport labels Nov 5, 2020
@kennyadsl kennyadsl added this to the 3.0.0 milestone Nov 5, 2020
@kennyadsl kennyadsl self-assigned this Nov 5, 2020
@kennyadsl
Copy link
Member Author

Merging without waiting 24 hours, this is breaking all extensions specs.

@kennyadsl kennyadsl merged commit 304da6d into solidusio:master Nov 6, 2020
@kennyadsl kennyadsl deleted the kennyadsl/lock-rails-6.0 branch November 6, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error, flaw or fault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants