Update order_tabs Order number format #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetticode
approved these changes
Nov 25, 2020
kennyadsl
added
changelog:solidus_backend
|
Thanks @brchristian, we will merge this in Solidus 3.1! |
kennyadsl
removed
the
release:major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many Solidus objects have a "number" field, including Orders, Shipments, Payments, etc. Counterintuitively this "number" generally begins with a letter. :) It’s "R" in the case of Orders, "H" in the case of Shipments, etc.
In almost all cases we simply display this as a string:
However, there is one exception, which is the Order breadcrumb, which prepends a "#" symbol:
This PR removes the "#" in the Order breadcrumb for consistency with other Order views as well as Shipments, Payments, etc.