Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow customize database credentials for test app #3921

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

ccarruitero
Copy link
Contributor

Description
This allow set postgresql database credentials for dummy app from env variables.

I think not everyone use default postgresql credential, and this will be useful in that cases.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Sorry, something went wrong.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@kennyadsl kennyadsl added this to the 3.0.0 milestone Feb 15, 2021
@kennyadsl kennyadsl merged commit 68fcf04 into solidusio:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants