Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline the attachment form for taxon icons #3932

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion backend/app/views/spree/admin/taxons/_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,24 @@
</div>
<% end %>

<%= render "spree/admin/taxons/attachment_forms/#{f.object.attachment_partial_name}", f: f %>
<% if f.object.class.attachment_definitions.size > 1 %>
<%= render "spree/admin/taxons/attachment_forms/#{f.object.attachment_partial_name}", f: f %>
<% else %>
<%= f.field_container :icon do %>
<%= f.label :icon %><br>
<%= f.file_field :icon %>
<% if f.object.icon_present? %>
<%= image_tag f.object.icon(:mini) %>
<%= link_to t('spree.actions.remove'),
admin_taxonomy_taxon_attachment_path(@taxonomy,
@taxon.id,
attachment_definition: :icon,
authenticity_token: form_authenticity_token),
method: :delete,
class: 'btn btn-sm btn-danger' %>
<% end %>
<% end %>
<% end %>
</div>

<div class="col-5">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
<%
Spree::Deprecation.warn(
"This partial with its support for multiple Spree::Taxon attachments is deprecated and will be removed in a future " \
"version of Solidus, please overwrite the standard view if you need to support custom attachments."
)
%>

<% f.object.class.attachment_definitions.each do |attachment, definition| %>
<%= f.field_container attachment do %>
<%= f.label attachment %><br>
Expand Down
3 changes: 1 addition & 2 deletions core/app/models/spree/taxon/active_storage_attachment.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@ module Spree::Taxon::ActiveStorageAttachment
styles: { mini: '32x32>', normal: '128x128>' },
default_style: :mini
validate :icon_is_an_image


end

def attachment_partial_name
Spree::Deprecation.warn("calling #attachment_partial_name on Spree::Taxon is deprecated without replacement.")
'paperclip'
end
end
1 change: 1 addition & 0 deletions core/app/models/spree/taxon/paperclip_attachment.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def icon_present?
end

def attachment_partial_name
Spree::Deprecation.warn("calling #attachment_partial_name on Spree::Taxon is deprecated without replacement.")
'paperclip'
end

Expand Down