Promotion rule product limit improvements #3934
Conversation
|
let me know if I have to squash or reformulate the commit messages |
|
sure, on it! |
remove per_page param from product listing for admin search in backend
nirnaeth
force-pushed
the
promotion_rule_product_limit
branch
from
c002e2d
to
6aa7c0c
Compare
|
@kennyadsl do I need to do anything else? |
|
Nope, this is good thanks. We will wait for the next release before merging this. Going to add the right labels/milestone so it's clear for everybody. Thanks again! 🙏 |
kennyadsl
added
the
release:major
| end | ||
| end | ||
|
|
||
| context 'when a per page limit is not set' do |
There was a problem hiding this comment.
It seems to me that this context expectations are the same as the context above, only the params are slightly different, so it's not evident to me what difference in result the different params should produce... so I'm missing the reason for this second test 😅. Can you help me with that?
There was a problem hiding this comment.
It is basically testing that, no matter which per_page you are requesting, when there's the show_all option it will return all the records, ignoring the per_page param. Makes sense @spaghetticode?
There was a problem hiding this comment.
@kennyadsl sure... thanks!
kennyadsl
removed
the
release:major
Description
Ref #3902
Adding a further parameter
show_allto theselect2rule when picking products in the admin interface.The parameter should act only when the selection is initialized at page load and should not have an impact on the product drop-down.
Now the promotion rule section for products should properly show all products associated with the rule and not just up to a certain limit as described in #3902 .
Screenshots
With 8 products associated to the rule:
Before
After
Checklist:
Credits
@aldesantis for the lead