Avoid too many prompts during solidus:install generator #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it is asking to run migrations after each extra plugin installation. This is not needed because migrations are copied anyway during the install and we will run all the migrations together at the end of the process.
kennyadsl
changed the title
aldesantis
approved these changes
Feb 16, 2021
jarednorman
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the
solidus:installgenerator is asking if we want to run migrations with a prompt (yes/no) after each extra plugin installations (authentication and payment method). This is not needed because migrations are copied anyway during the install and we will run all the migrations together at the end of the process. In fact,--skip-migrations=truedoes not skip copying migrations but only avoid the prompt that asks to run them immediately after the copy.I tested this fix on a brand new application.
Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)