Install Active Storage by default on new stores #3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
approved these changes
Feb 16, 2021
aldesantis
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
@kennyadsl +1 for removing Paperclip as a core dependency and moving it to the Gemfile instead. Should we do it in this PR or another one?
|
@aldesantis it would be great but, as always, it is more complex than expected. Paperclip is still required when Solidus runs with Rails <= 6.0, so if we remove it from core dependencies we will break backward compatibility for people updating Solidus but not Rails. Also, our CI uses it when running specs against Rails 5.2 and 6.0. |
|
💯 |
SamuelMartini
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 5, 2021
As active storage is default in new stores solidusio#3938 the generated dummy app needs to be configured so that new extensions can tests with it.solidusio#3967
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are ready to default to Active Storage and it would be great for Solidus 3.0 to ship with this new default.
We can also investigate removing paperclip as a dependency of core and re-adding it optionally with the installer in the host application Gemfile.