Fix order checkout flow completion with custom steps #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Spree::Order model has a configurable checkout flow where steps can be customised. One of the configurable steps is 'confirm'. As a result, the 'confirm' step is optional. The code defining the transition for the 'complete' event was still only transitioning from the 'confirm' state, rather than from the last configured checkout flow state. This was causing a problem in case the 'confirm' step was actually missing. This commit removes the hardwired 'confirm' state reference and obtains the last configured flow state instead.
nerfologist
changed the title
kennyadsl
approved these changes
Feb 22, 2021
jarednorman
approved these changes
Feb 25, 2021
kennyadsl
added
release:major
kennyadsl
added
Important Change
and removed
release:major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Description:
The
Spree::Ordercheckout flow is configurable and steps (states) can be added or removed. Unfortunately, removing theconfirmstate was causing issue #3926 since the code for thecompleteevent was still taking for granted that theconfirmstate was part of the flow.This PR fixes the problem by plugging in the last step of the configurable checkout flow instead.
Also, a paragraph explaining how to customize the checkout flow has been added to the
Orderdocumentation, since the feature is available in the codebase.Fixes #3926.