Add Post-Install message to Solidus 3.0 #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
approved these changes
Mar 13, 2021
They should be ran with the code present in Solidus 2.11 so it's useless to keep them here as well.
We already introduced this post-install message in 2.11.5 when we started requesting users to run a rake task after bumping Solidus. Even if we don't have any specific rake task here in 3.0 we can keep this convention so we always have a place where to put this kind of tasks. Also, we can be consistent between versions in terms of how we request people to upgrade Solidus: 1. Change Gemfile 2. Run `bin/rails solidus:upgrade` Even if it does nothing special, I think it's a positive thing to have.
kennyadsl
force-pushed
the
kennyadsl/post-install-message
branch
from
7c1da5d to
f9b317c
Compare
mamhoff
pushed a commit
to mamhoff/solidus
that referenced
this pull request
Mar 29, 2021
…-message Add Post-Install message to Solidus 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similarly to what we did in the
v2.11branch with #3945, we can add a gem post-install message that will be shown whensolidus-corewill be installed or updated. We usedsolidus-coreso that the message will be visible to people using only some submodules of Solidus, instead of the whole wrapper gem.This PR also adds a generic
solidus:upgradetask that will be installed in host applications.Even if we don't have any specific rake task here in 3.0 we can keep this convention so we always have a place where to
put this kind of tasks.
Also, we can be consistent between versions in terms of how we request people to upgrade Solidus:
bin/rails solidus:upgrade