Only run spring stop in install generator if spring is available #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `spring stop` command in the install generator was being run even if spring is not installed. We should only run this command if Spring is available. Co-authored-by: Mike Conlin <mike@super.gd>
Noah-Silvera
changed the title
Noah-Silvera
changed the title
|
I'm not sure if this change needs tests - no tests for the |
|
Thanks, this was so annoying! |
spaghetticode
approved these changes
Mar 17, 2021
swively
approved these changes
Mar 26, 2021
jarednorman
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
spring stopcommand in the install generator was being run even if spring is not installed. This command was causing the install generator to report an error.We should only run this command if Spring is available.
Checklist: