Failing spec for calculator with preferences that aren't known #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try accessing a calculator with preferences in the DB, and that calculator hasn't seen the `serialize` call, Rails will try accessing the preferences column directly and return a string :(
houndci-bot
reviewed
Mar 25, 2021
|
|
||
| let!(:shipping_methods) do | ||
| [ | ||
| create(:shipping_method, calculator: Spree::Calculator::Shipping::WithUnknownPreferences.new(preferences: {a: "b"})) |
There was a problem hiding this comment.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
| @@ -105,7 +105,25 @@ def compute_package(_package) | |||
|
|
|||
| let!(:shipping_methods) do | |||
| [ | |||
| create(:shipping_method, calculator: Spree::Calculator::Shipping::NoPreferences.new) | |||
| create(:shipping_method, calculator: Spree::Calculator::Shipping::NoPreferences.new()) | |||
There was a problem hiding this comment.
Style/MethodCallWithoutArgsParentheses: Do not use parentheses for method calls with no arguments.
|
Shouldn't those preferences be declared in the calculator with |
|
I've added this commit to #4013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try accessing a calculator with preferences in the DB, and that
calculator hasn't seen the
serializecall, Rails will try accessingthe preferences column directly and return a string :(
Checklist: