Include Preference Handling as a Module #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
preferences-3-0
branch
from
6de1757 to
fa07e70
Compare
We can't do this in Spree::Base as of Rails 6.1 as Rails 6.1 expects there to always be a preferences column if one calls `serialize :preferences, Hash`. Only a few classes have that column. This moves the code from Spree::Base into a module, and includes that in those classes that actually have a preferences column. There are no deprecations in this commit, as the deprecation work is done on the v2.11 branch.
If you try accessing a calculator with preferences in the DB, and that calculator hasn't seen the `serialize` call, Rails will try accessing the preferences column directly and return a string :(
These methods aren't available automatically any longer, thanks to Rails 6.1. They actually weren't in the first place, because not every model has a `preferences` column.
mamhoff
force-pushed
the
preferences-3-0
branch
from
fa07e70 to
adc46c3
Compare
jarednorman
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This takes the work from #4013 and merges it to the main branch. I've removed the deprecation warnings and related specs.
Checklist: