-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update defaults in dummy application #4047
Update defaults in dummy application #4047
Conversation
Hmm. Some tests failing on CI but not on my local machine. I'll try to figure it out. |
I think it'll be green once #4048 is merged |
077729e
to
f523921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @waiting-for-dev.
6208ac4
to
556596a
Compare
@waiting-for-dev did we remove the grouping suggested by Jared with the last commit? |
556596a
to
ca0603d
Compare
Thanks for catching it @kennyadsl . As I directly committed the suggestion but didn't update my local repo, I override when forced the push 🙈 Sorry for that 😞 Just fixed it. |
No problem, we are here to review! |
Here it's a description of the reason for each change. Keep in mind that CI test against Rails 5.2 as the minimal version: - serve_static_assets: Removed it. It's [not available since Rails 5.0](https://guides.rubyonrails.org/5_0_release_notes.html#railties-removals). - public_file_server.enabled: Set explicitly to `true`. Even if it was already `true`, a [real Rails application will default it to `false` in the production environment unless a env variable `RAILS_SERVE_STATIC_FILES` is present](https://github.com/rails/rails/blob/f95c0b7e96eb36bc3efc0c5beffbb9e84ea664e4/railties/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt#L27). This way it's less surprising. - whiny_nils: Removed. It's [not available since Rails 4.1](https://guides.rubyonrails.org/4_1_release_notes.html#railties-removals). - action_controller.allow_forgery_protection: Set to true to mimic production. - action_controller.default_protect_from_forgery: Set to true to mimic production. - action_controller.perform_caching: Set to true to mimic production. - active_support.deprecation: Remove duplicated entry. - action_mailer.delivery_job: Removed because `load_defaults` take care of it. - storage_path: Removed. It wasn't a Rails setting, but used as a convenience. It was confusing. - action_controller.include_all_helpers: Removed as it's already the default. - log_level: Added. It already defaulted to `:debug`, but a real Rails app will default to `:info` in production. To make things less surprising let's be explicit. - action_mailer.perform_caching: Added to mimic production. - i18n.fallbacks: Added to mimic production. - active_record.dump_schema_after_migration: Added to mimic production and for better performance. - assets: There's no need to check whether it's a method on `config`. See solidusio#4035
ca0603d
to
93529a6
Compare
Here it's a description of the reason for each change. Keep in mind that
CI test against Rails 5.2 as the minimal version:
serve_static_assets: Removed it. It's not available since Rails
5.0.
public_file_server.enabled: Set explicitly to
true
. Even if it wasalready
true
, a real Rails application will default it tofalse
inthe production environment unless a env variable
RAILS_SERVE_STATIC_FILES
ispresent. This way it's less surprising.
whiny_nils: Removed. It's not available since Rails
4.1.
action_controller.allow_forgery_protection: Set to true to mimic
production.
action_controller.default_protect_from_forgery: Set to true to mimic
production.
action_controller.perform_caching: Set to true to mimic production.
active_support.deprecation: Remove duplicated entry.
action_mailer.delivery_job: Removed because
load_defaults
take care ofit.
storage_path: Removed. It wasn't a Rails setting, but used as a
convenience. It was confusing.
action_controller.include_all_helpers: Removed as it's already the
default.
log_level: Added. It already defaulted to
:debug
, but a real Rails appwill default to
:info
in production. To make things less surprisinglet's be explicit.
action_mailer.perform_caching: Added to mimic production.
i18n.fallbacks: Added to mimic production.
active_record.dump_schema_after_migration: Added to mimic production and
for better performance.
assets: No need to check whether it's a method on
config
.See #4035
Checklist: