Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Spree::Promotion.has_actions scope #4056

Merged
merged 1 commit into from
May 28, 2021
Merged

Fix Spree::Promotion.has_actions scope #4056

merged 1 commit into from
May 28, 2021

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented May 11, 2021

The scope would return multiple copies of the same promotion without
this change.

I hope this bug does not result in duplicate promotions being applied to orders. The bug is also present in 2.9.11, and might warrant a backport.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (if needed)

@mamhoff
Fix Spree::Promotion.has_actions scope
9a826fb 
The scope would return multiple copies of the same promotion without
this change.
@kennyadsl
Copy link
Member

CI is red due to #4055.

@kennyadsl kennyadsl merged commit 05a14cd into solidusio:master May 28, 2021
@kennyadsl kennyadsl added the changelog:solidus_core Changes to the solidus_core gem label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mamhoff @kennyadsl @jarednorman