Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Cancel" URL link on reimbursement edit page #4061

Merged
merged 1 commit into from
May 17, 2021
Merged

Fix "Cancel" URL link on reimbursement edit page #4061

merged 1 commit into from
May 17, 2021

Conversation

spaghetticode
Copy link
Member

The error ActionController::RoutingError is raised when the "Cancel" button is pressed, since the route entry for the action Spree::Admin::CustomerReturnsController#show is missing. In this case, we need to use the edit action.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Screen Shot 2021-05-13 at 12 33 07 PM

@spaghetticode
Fix "Cancel" URL link
eaf841c 
The error `ActionController::RoutingError` is raised when the
"Cancel" button is pressed, since the route entry for the action
`Spree::Admin::CustomerReturnsController#show` is missing. In
this case, we need to use the `edit` action.
@spaghetticode spaghetticode added the type:bug Error, flaw or fault label May 13, 2021
@spaghetticode spaghetticode self-assigned this May 13, 2021
@kennyadsl
Copy link
Member

It's not clear why we need to keep the Cancel text to edit it?

@spaghetticode
Copy link
Member Author

@kennyadsl sorry I don't understand, can you please elaborate more?

@kennyadsl
Copy link
Member

Sorry, I misunderstood what cancel does badly. I thought it was to cancel the reimbursement and now I get that it's to cancel the current action and go back to the previous page. Ignore me!

kennyadsl
kennyadsl approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kennyadsl kennyadsl merged commit 6d5440f into solidusio:master May 17, 2021
@kennyadsl kennyadsl deleted the spaghetticode/fix-cancel-link branch May 17, 2021 09:58
@kennyadsl kennyadsl added the changelog:solidus_backend Changes to the solidus_backend gem label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@spaghetticode spaghetticode

Labels
changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaghetticode @kennyadsl @jarednorman