Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3 #4072

Merged
merged 1 commit into from
May 25, 2021
Merged

Support Ruby 3 #4072

merged 1 commit into from
May 25, 2021

Conversation

waiting-for-dev
Copy link
Contributor

Besides a couple of issues related to the new separation between
keyword and positional
arguments
,
this bug rails/rails#42098 is currently
hitting us. As we don't need to do anything from our side, we mark our
failing example so that we'll notice when it gets fixed upstream.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waiting-for-dev !

Besides a couple of [issues related to the new separation between
keyword and positional
arguments](https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/),
this bug rails/rails#42098 is currently
hitting us. As we don't need to do anything from our side, we mark our
failing example so that we'll notice when it gets fixed upstream.
@kennyadsl kennyadsl merged commit d6e84ec into solidusio:master May 25, 2021
@kennyadsl kennyadsl deleted the waiting-for-dev/ruby3 branch May 25, 2021 07:41
@kennyadsl kennyadsl added the changelog:solidus_core Changes to the solidus_core gem label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants