Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update billing address migration tasks with batch limit #4104

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Update billing address migration tasks with batch limit #4104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions core/lib/tasks/migrations/migrate_default_billing_addresses_to_address_book.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,29 @@
namespace :solidus do
namespace :migrations do
namespace :migrate_default_billing_addresses_to_address_book do
task up: :environment do
print "Migrating default billing addresses to address book ... "
task :up, [:batch_size] => [:environment] do |_t, args|
batch_size = args[:batch_size] || 100_000
print "Migrating default billing addresses to address book in batches of #{batch_size} ... "
if Spree::UserAddress.where(default_billing: true).any?
Spree.user_class.joins(:bill_address).update_all(bill_address_id: nil) # rubocop:disable Rails/SkipsModelValidations
Spree.user_class.joins(:bill_address).in_batches(of: batch_size).each do |batch|
batch.update_all(bill_address_id: nil) # rubocop:disable Rails/SkipsModelValidations
end
end
Spree::UserAddress.joins(
<<~SQL
JOIN spree_users ON spree_user_addresses.user_id = spree_users.id
AND spree_user_addresses.address_id = spree_users.bill_address_id
SQL
).update_all(default_billing: true)
).in_batches(of: batch_size).each do |batch|
batch.update_all(default_billing: true) # rubocop:disable Rails/SkipsModelValidations
end

puts "Success"
end

task down: :environment do
Spree::UserAddress.update_all(default_billing: false) # rubocop:disable Rails/SkipsModelValidations
task :down, [:batch_size] => [:environment] do |_t, args|
batch_size = args[:batch_size] || 100_000
Spree::UserAddress.in_batches(of: batch_size).update_all(default_billing: false) # rubocop:disable Rails/SkipsModelValidations
puts "Rolled back default billing address migration to address book"
end
end
Expand Down
4 changes: 2 additions & 2 deletions core/spec/lib/tasks/migrations/migrate_default_billing_addresses_to_address_book_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it 'runs' do
expect { task.invoke }.to output(
"Migrating default billing addresses to address book ... Success\n"
"Migrating default billing addresses to address book in batches of 100000 ... Success\n"
).to_stdout
end

Expand Down Expand Up @@ -63,7 +63,7 @@

it 'runs' do
expect { task.invoke }.to output(
"Migrating default billing addresses to address book ... Success\n"
"Migrating default billing addresses to address book in batches of 100000 ... Success\n"
).to_stdout
end

Expand Down