Fix flaky product feature spec #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 25, 2021 08:35
Fixes solidusio#4110. Based on the spec description, it's unlikely that the spec intended to visit the root path twice, while setting up the variants in between visits. Analysis of the cause of the flaky spec can be found at solidusio#4110 (comment).
It doesn't appear that the visit is relevant to the Russian Rubles specs.
It doesn't appear that the spec is intentionally visiting the page before setting up the fixtures.
gsmendoza
force-pushed
the
4110-flaky-feature-spec-detected-fix
branch
from
ec7a554 to
4161874
Compare
gmacdougall
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4110.
Compared to #4114, this PR separates the refactoring part of the fix (inlining the
root_pathvisit) from the actual fix. The PR also individually improves the other specs affected by the refactoring, documenting in the commits why the improvements were safe to make.Video walk-through of the PR
https://www.dropbox.com/s/jo4fctehbdhsmix/4118-walkthough-2021-06-25_08.28.36.mp4?dl=0
Relevant links
Checklist