Exclude canceled orders in the #usage_count of promotions and promotion codes #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikraamg
force-pushed
the
exclude-canceled-orders-from-promotioncount
branch
from
299396d to
b71e450
Compare
There was a problem hiding this comment.
I think the feature change makes sense, but I see a couple of issues, the first one is related to large datasets (see the other comment), the second one is we're changing the original behavior, so I'm wondering if we should give the possibility to keep the old one (for example via a config flag) or if the change is so common sense that we should consider the original behavior almost a bug.
ikraamg
force-pushed
the
exclude-canceled-orders-from-promotioncount
branch
from
62130e4 to
1745930
Compare
jarednorman
approved these changes
Jul 7, 2021
ikraamg
force-pushed
the
exclude-canceled-orders-from-promotioncount
branch
from
1745930 to
631ef0b
Compare
houndci-bot
reviewed
Jul 7, 2021
This allows for a more accurate count of promotion/promotion_code usage. The exclusion was kept as an optional boolean within`Adjustment` `#in_completed_orders` to keep backward compatibility and allow for canceled orders to be excluded within a single query when required.
ikraamg
force-pushed
the
exclude-canceled-orders-from-promotioncount
branch
from
631ef0b to
843df0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is extracted from a clients project. I thought it might be useful to have this on Solidus because excluding the count of canceled orders in
#usage-countallows for a more accurate count(and limit) of promotions and promotion_codes.Checklist: