Fix displaying of discarded variants in admin #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the default scope added in solidusio@466251e, the `discarded` scope currently operates on the default `kept` scope and returns an empty set. This fixes the scope for checking the `discarded` variants as suggested here https://github.com/jhawthorn/discard#default-scope, to correctly display the "deleted variants" filter in the admin variants page.
spaghetticode
approved these changes
Aug 20, 2021
jarednorman
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this, discarded variants are not displayable anymore because
Discard#discardedscope now operates onkeptscope and finds no result if not prepended with a larger scope, as suggested here.This prevents the "deleted variants" filter from being displayed in the variants list on the admin panel.
This PR provides a quick fix for displaying the "deleted variants" filter again in the admin variants, which allows to display the deleted variants again.
Two alternative solutions that I considered, with the help of @spaghetticode:
discardedscope: this implementation would be very dependent on the soft deletion gem in-use, because (as far as I know) there is no way to call thesuperscope from its override. It would have resulted in something likescope :discarded, -> { with_discarded.where.not(deleted_at: nil) }.So I thought that the solution I'm proposing was more reasonable, let me know your thoughts if you disagree or I'm missing something.
Checklist: