Fix searching deleted products by SKU #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This scope is currently only in use on the product search page. Unfortunately, it did not return the correct results when attempting to search with "deleted" products by SKU. This is due to the scope excluding any discarded variants by default. To remedy the issue, we've addded a second scope that will include the discarded variants in the results. We've also renamed the old scope to better reflect what it is doing and have added a deprecation for the old method name.
We're going to want to be able to filter products using our new variant SKU scopes that correctly consider discarded variants.
Now that we've got a new scope we can use that will correctly return products with discarded variants, we've updated the admin interface to use it. This meant adding a new Backbone view to help control the two inputs we now have on the page, one for each scope. It will hide and disable the appropriate input based on the value of the "with deleted" checkbox.
jarednorman
approved these changes
Sep 14, 2021
kennyadsl
added
changelog:solidus_backend
kennyadsl
approved these changes
Sep 17, 2021
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 28, 2023
Please use with_kept_variant_sku_cont now. Ref solidusio#4164
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 12, 2023
Please use with_kept_variant_sku_cont now. Ref solidusio#4164
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 14, 2023
Please use with_kept_variant_sku_cont now. Ref solidusio#4164
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 18, 2023
Please use with_kept_variant_sku_cont now. Ref solidusio#4164
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 18, 2023
Please use with_kept_variant_sku_cont now. Ref solidusio#4164
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 19, 2023
Please use with_kept_variant_sku_cont now. Ref solidusio#4164
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 24, 2023
Please use with_kept_variant_sku_cont now. Ref solidusio#4164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added two new scopes to
Spree::Productand deprecated on existing one.with_variant_sku_cont: Has been deprecated in favour ofwith_kept_variant_sku_contwith_all_variant_sku_cont: Will search for products that have a variant containing the provided SKU, even if it has been discarded.with_kept_variant_sku_cont: Maintains the existing behaviour ofwith_variant_sku_cont, but with a more descriptive name.This allows us, along with a new Backbone view to help control the two inputs we now have on the page (one for each scope), to correctly return deleted products when searching by SKU. Our view will swap out the inputs based on the value of the "with_deleted" checkbox so that the user experience is unchanged.
While attempting to fix this issue, there are a few other approaches we tried before settling on this one:
Fixes #3912
Checklist:
I have updated Guides and README accordingly to this change (if needed)I have attached screenshots to this PR for visual changes (if needed)