Respect completed_at timestamp in order factories #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 14, 2021
DianeLooney
changed the title
DianeLooney
changed the title
DianeLooney
changed the title
DianeLooney
changed the title
jarednorman
approved these changes
Sep 14, 2021
The order factories that automatically complete orders previously used Time.current when setting the completed_at timestamp. For developers who want to pre-date their order completions, this can be confusing. This change allows orders to be cleanly pre-dated in this way.
|
Mysql tests failed because I was too granular with my timestamp comparison. I updated it to 5 seconds and force-pushed the fix. Sorry if anyone happened to catch the review super early! |
|
The failing postgres test looks like spec flake to me, I can reproduce it locally by |
|
Happy to simply rebase if/when this is merged, or if someone with ci powers wants to re-run for me I'd be happy with that too. |
jarednorman
approved these changes
Sep 14, 2021
core/spec/lib/spree/core/testing_support/factories/order_factory_spec.rb
Outdated
Show resolved
Hide resolved
A five second window was previously stored. A 1s window is too small because it might occur at the rollover to a new second, and mysql could flake on this. So, a two second window is appropriately small while still accounting for timestamps being truncated when stored. For example * Clock reads xx:yy:01.995 * Factory runs * MySQL stores xx:yy:01.000 * Clock now reads xx:yy:02.005 * Compare timestamps, 1.005s difference, test fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order factories that automatically complete orders previously used
Time.current when setting the completed_at timestamp. For developers who want
to pre-date their order completions, this can be confusing. This change allows
orders to be cleanly pre-dated in this way.
Checklist: