Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Good commit message link fixed #4186

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[Doc] Good commit message link fixed #4186

merged 1 commit into from
Oct 6, 2021

Conversation

shubham9411
Copy link
Contributor

Description

Hi,

I was going through the contributing guide and the link for writing good commit messages in the Pull Request guidelines section seems to be broken. The link points to a commit which is now moved to a different repo in another namespace. I have fixed it please have a look.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Link to Notes from Linus in CONTRIBUTING.md is broken because the
project has been moved to the subsurface namespace in github.
Updated the link with subsurface namespace.
@jarednorman
Copy link
Member

Thanks!

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jarednorman jarednorman merged commit a54f713 into solidusio:master Oct 6, 2021
@shubham9411 shubham9411 deleted the doc/link-fix-git-commit branch October 6, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants