List order customer returns only once #4196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer returns are associated to orders via return items. This means that, if an order has multiple line items and a single customer return for all of them, then the customer return will be listed twice. Listing customer returns multiple times adds noise without any significant benefit, and can be misleading when calling
order.customer_returns.size
and similars.Given this is an ActiveRecord feature, it doesn't make much sense to add a spec in the codebase for covering it, considering also that the spec would require the creation of many different records, but for the curious ones it can be verified with:
Checklist: