Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of small fixes #4205

Merged
merged 2 commits into from
Nov 18, 2021
Merged

A couple of small fixes #4205

merged 2 commits into from
Nov 18, 2021

Conversation

elia
Copy link
Member

@elia elia commented Nov 18, 2021

Description

The .gem file slipped in a changelog update commit 3b7a83e

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

waiting-for-dev
waiting-for-dev approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! ❤️

@waiting-for-dev waiting-for-dev merged commit 5d8d110 into solidusio:master Nov 18, 2021
@waiting-for-dev waiting-for-dev deleted the elia/fixes branch November 18, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elia @waiting-for-dev @kennyadsl