Make display_price optional on admin variants list #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
Thanks, @luca-landa! Could we have a test for that to avoid possible future regressions?
luca-landa
force-pushed
the
luca-landa/fix-variants-list-in-admin-with-not-fully-configured-prices
branch
2 times, most recently
from
c0b54b0 to
41c9017
Compare
When there are variants with not fully configured prices (e.g. because they are being created) the product variants page breaks without the admin really knowing why. This allows for the variants list to be displayed anyway.
luca-landa
force-pushed
the
luca-landa/fix-variants-list-in-admin-with-not-fully-configured-prices
branch
from
41c9017 to
c2d4424
Compare
@waiting-for-dev added! I wasn't sure if I should have created a factory for the variant needed in this test, being a unique use case, let me know if you think I should change something 🙏 |
waiting-for-dev
approved these changes
Nov 30, 2021
Thanks, @luca-landa! I think there's no need for a custom factory 🙂 |
jarednorman
approved these changes
Dec 1, 2021
|
This should be backported to v3.1 and v3.0 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are variants which respond
nilas#default_price(e.g. because admin is creating them and they still don't have all prices set up, or they don't have a price matchingSpree::Variant.default_price_attributes), the/admin/products/<product>/variantspage returns 500 and it's not obvious why to the admin.This small fix allows for the variants list page to be displayed anyway.
Description
Checklist: