Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update warning with copy/pastable code #4215

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Update warning with copy/pastable code #4215

merged 1 commit into from
Nov 30, 2021

Conversation

peterberkenbosch
Copy link
Contributor

@peterberkenbosch peterberkenbosch commented Nov 29, 2021 •
edited
Loading

Description

Fix typo in the the code sample deprecation warning for the Spree event adapters

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

jarednorman
jarednorman approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter!

waiting-for-dev
waiting-for-dev approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@waiting-for-dev waiting-for-dev merged commit 9dbcad1 into solidusio:master Nov 30, 2021
@waiting-for-dev waiting-for-dev mentioned this pull request Apr 15, 2022
Merged
5 tasks
@peterberkenbosch peterberkenbosch deleted the typo-on-event-deprecation-warning branch August 24, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adammathys adammathys adammathys approved these changes

@jarednorman jarednorman jarednorman approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterberkenbosch @waiting-for-dev @jarednorman @adammathys