Documentation fixes #4241
Merged
Documentation fixes #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the documentation match with the next section, the order_mailer_class example should be set to Spree::CustomOrderMailer instead.
kennyadsl
approved these changes
Jan 13, 2022
| @@ -91,7 +91,7 @@ Solidus initializer: | |||
| # config/initializers/spree.rb | |||
|
|
|||
| Spree.config do |config| | |||
| config.order_mailer_class = 'c' | |||
|
For some reason, the Ci didn't run. @nbelzer can you please try to force push again to see if it's triggered this time? |
|
@kennyadsl I ran |
|
It seems CI is skipped for guides-only changes: Line 43 in 3d7389e |
|
🤦♂️ you are right @waiting-for-dev! |
jarednorman
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reading the developer guides I found a few typos, a missing link, one formatting error, and a missing piece of code. In this PR I have included a fix/update for each of these (each as separate commit).
The missing piece fo code is defined in guides/source/developers/customizations/customizing-mailers.html.md. I believe to have updated it correctly, such that it matches the section that comes after it (which introduces the
Spree::CustomOrderMailer).Checklist:
I have updated Guides and README accordingly to this change (if needed)I have added tests to cover this change (if needed)middleman server