Fix order create permissions #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `DefaultCustomer` is the default role that's mixed into every ability, we basically had no restrictions in regards to creating orders so far. This change will allow order creation when: * the order user is the same as the ability user; * the order user and the ability user are both missing; * order.email is present (guest checkout order); * the order token matches the API token
We've been using `manage` because `can? :create` was always true because of very lax `DefaultCustomer` permission definitions. The Order create definition was restricted with 50393da, so now we can start using `create` again.
This permission check was introduced in order to avoid showing a link to the form for creating a new order from a partial that uses the `can? :create, resource` permission check.
|
Following @kennyadsl's suggestion, I tested |
tvdeyen
approved these changes
Mar 2, 2022
waiting-for-dev
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #4248
This PR aims at fixing permission checks for showing the
new orderbutton in the admin area.We're currently using the
managepermission, which seems to be a bit too much for just showing a button, given thatmanageis the maximum level of permission for a resource. Checking for thecreatepermission would be much more appropriate.In order to achieve the goal, the
DefaultCustomerpermission rule for creating orders has been made stricter, so by default users can create a order only when:emailfield (guest checkout);A few specs were updated, as a consequence.
Checklist: