Admin permission fixes #4276
Merged
Admin permission fixes #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This button should be visible only to users that can `create` adjustment reasons.
This button should be visible only to users that can `create` store credit reasons.
The previous check `can? :admin` was not particularly useful, as it didn't prevent anybody who have generic access to the resource to attempt editing this data.
spaghetticode
force-pushed
the
spaghetticode/admin-permission-fixes
branch
from
0db65d4 to
963aaed
Compare
jarednorman
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few permission checks in the admin area that were either missing or wrong.
Checklist: