Optimize Spree::PromotionHandler::Cart #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Feb 24, 2022
kennyadsl
reviewed
Mar 15, 2022
I don't really as removing n+1s have peculiar performance characteristics: In isolation, there isn't much in terms of performance improvement you'll see. In our app, this and other n+1 removals (see some of my other PRs) reduced the time for add-to-cart (in which we check stock availability) from up to a minute (!) to consistently under a half a second. However, this was not this PR alone, and dependent on very diligently preloading records in our controllers. |
We can preload promotion rules AND actions, and we can use the promotions already loaded on the order instead of going through an extra DB query.
This prevents n+1 queries when loading and applying promotions.
This way, order promotions can be preloaded.
mamhoff
force-pushed
the
optimize-promotion-handler-cart
branch
2 times, most recently
from
07d785f to
69d28b2
Compare
Some rules and actions need to preload related records for performance reasons. Prior to this commit, the promotion handler needed to know which rules need to preload which relations; with this commit we have a simple API that helps rule authors define preload relations without having to modify the promotion handler.
mamhoff
force-pushed
the
optimize-promotion-handler-cart
branch
from
69d28b2 to
0e8c6ca
Compare
kennyadsl
approved these changes
Mar 30, 2022
jarednorman
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the default cart promotion handler by preloading records and taking advantage of already preloaded records where possible.
Checklist: