Promotion Rule CreateItemAdjustments: Use in-memory objects #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the function that obtains the line items of an order to create adjustments for to use in-memory objects rather than querying the database for line items that have no adjustments with a source from the current rule. Promotion rules can easily be preloaded, and there's no need for the DB call in the previous code.
jarednorman
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the function that obtains the line items of an order to
create adjustments for to use in-memory objects rather than querying the
database for line items that have no adjustments with a source from the
current rule.
Promotion rules can easily be preloaded, and there's no need for the DB
call in the previous code.
Checklist: