Refactor Stock Quantifier to use Enumerable #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
remove-n+1-from-stock-quantifier
branch
from
5fefd82 to
9ec786c
Compare
jarednorman
reviewed
Mar 3, 2022
mamhoff
force-pushed
the
remove-n+1-from-stock-quantifier
branch
from
9ec786c to
ff93926
Compare
tvdeyen
approved these changes
Mar 4, 2022
frontend/spec/features/checkout_confirm_insufficient_stock_spec.rb
Outdated
Show resolved
Hide resolved
mamhoff
force-pushed
the
remove-n+1-from-stock-quantifier
branch
from
ff93926 to
e0c6c91
Compare
jarednorman
approved these changes
Mar 9, 2022
kennyadsl
reviewed
Mar 15, 2022
frontend/spec/features/checkout_confirm_insufficient_stock_spec.rb
Outdated
Show resolved
Hide resolved
This allows a developer to preload stock items and stock location, removing many, many n+1 queries to the database.
mamhoff
force-pushed
the
remove-n+1-from-stock-quantifier
branch
from
e0c6c91 to
1b2cf01
Compare
We need to reload the variant's stock items in these before blocks now, otherwise the code under test doesn't see that the count on hand has changed.
mamhoff
force-pushed
the
remove-n+1-from-stock-quantifier
branch
from
1b2cf01 to
c8cc04b
Compare
jarednorman
approved these changes
Mar 30, 2022
kennyadsl
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
Apr 22, 2022
As done in the main repository, there are some changes needed in the specs after some changes happened in the StockQuantifier. See solidusio/solidus#4291 for more information.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a developer to preload stock items and stock location,
removing many, many n+1 queries to the database.
Checklist: