-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes defining thumbnail sizes through ActiveStorage adapter #4318
Merged
+83
−10
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
core/spec/models/spree/concerns/active_storage_adapter/attachment_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'rails_helper' | ||
|
||
unless ENV['DISABLE_ACTIVE_STORAGE'] | ||
RSpec.describe Spree::ActiveStorageAdapter::Attachment do | ||
describe '#variant' do | ||
it "converts to resize_to_limit when definition doesn't contain any special symbol" do | ||
image = create(:image) | ||
|
||
attachment = described_class.new(image.attachment.attachment, styles: { mini: '10x10' }) | ||
|
||
expect( | ||
attachment.variant(:mini).variation.transformations | ||
).to include(resize_to_limit: [10, 10]) | ||
end | ||
|
||
it 'converts to resize_to_limit when definition ends with >' do | ||
image = create(:image) | ||
|
||
attachment = described_class.new(image.attachment.attachment, styles: { mini: '10x10>' }) | ||
|
||
expect( | ||
attachment.variant(:mini).variation.transformations | ||
).to include(resize_to_limit: [10, 10]) | ||
end | ||
|
||
it 'converts to resize_to_fill when definition ends with ^' do | ||
image = create(:image) | ||
|
||
attachment = described_class.new(image.attachment.attachment, styles: { mini: '10x10^' }) | ||
|
||
expect( | ||
attachment.variant(:mini).variation.transformations | ||
).to include(resize_to_fill: [10, 10]) | ||
end | ||
|
||
it 'strips definitions' do | ||
image = create(:image) | ||
|
||
attachment = described_class.new(image.attachment.attachment, styles: { mini: ' 10x10 ' }) | ||
|
||
expect( | ||
attachment.variant(:mini).variation.transformations | ||
).to include(resize_to_limit: [10, 10]) | ||
end | ||
|
||
|
||
it "defaults to the image's width and height" do | ||
image = create(:image) | ||
|
||
attachment = described_class.new(image.attachment.attachment, styles: {}) | ||
|
||
expect( | ||
attachment.variant(:mini).variation.transformations | ||
).to include(resize_to_limit: [attachment.width, attachment.height]) | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually has to be
for
resize_to_fill
, because it crops the image to fill the space. See https://github.com/janko/image_processing/wiki/Resize-To-FillThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually,
image_processing
transformsresize_to_fill
into^
:https://github.com/janko/image_processing/blob/12e7cf50b512d0f4c0735138013c5ea6d87fdee5/lib/image_processing/mini_magick.rb#L74
See also docs in imagemagick.
Do I get it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I see, this seems to be a Dragonfly thing. Really confusing actually, because Dragonfly just forwards the string to
convert -thumbnail
https://markevans.github.io/dragonfly/imagemagick#thumb