Remove deprecated_address_id column from shipments #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
remove-deprecated-address-id-column-from-shipments
branch
from
122197d to
d6ba29e
Compare
tvdeyen
approved these changes
Apr 13, 2022
We have not used this column since we removed all references to it in 2016.
mamhoff
force-pushed
the
remove-deprecated-address-id-column-from-shipments
branch
from
d6ba29e to
e81d213
Compare
jarednorman
approved these changes
Apr 13, 2022
|
Thanks! |
4 tasks
|
I'm tempted to revert this change and push it to the next major. Releasing this change with a minor could create more problems than it solves. @mamhoff @waiting-for-dev @tvdeyen what do you think? |
|
Sure, if you think so. |
|
It makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have not used this column since we removed all references to it in
2016.
Checklist: