Update in-memory shipments of order in order_shipping #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@solidusio/core-team I would like to back port this into 2.11, since this is a long standing bug. |
This was referenced Apr 13, 2022
|
Failing specs should be fixed with #4338 |
mamhoff
reviewed
Apr 13, 2022
tvdeyen
force-pushed
the
fix-determine-shipment-state
branch
from
99c496d to
b9c4b94
Compare
kennyadsl
reviewed
Apr 13, 2022
jarednorman
reviewed
Apr 13, 2022
Since we update the shipments state in the database, but we read the shipsments from memory in the OrderUpdater#determine_shipment_state we need to set the new values here on the object as well. Co-authored-by: darkswoop <benny@digitalbehr.de>
tvdeyen
force-pushed
the
fix-determine-shipment-state
branch
from
b9c4b94 to
63241b8
Compare
jarednorman
approved these changes
Apr 20, 2022
waiting-for-dev
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we update the shipments state in the database,
but we read the shipsments from memory in the
OrderUpdater#determine_shipment_state we need to set the new
values here on the object as well.
Checklist: