Fix creating refund with amount in foreign format #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
approved these changes
Apr 20, 2022
This was referenced Apr 20, 2022
jarednorman
approved these changes
Apr 20, 2022
tvdeyen
force-pushed
the
fix-refund-form-input-format
branch
from
6b21644 to
ef961d9
Compare
|
Will re-open the PR because circle ci didn't picked it up |
The numericality validation in rails cannot handle prices in non-float based amounts (Ie. 100,00 EUR). Using `Spree::LocalizedNumber` to convert the amount before validation.
tvdeyen
force-pushed
the
fix-refund-form-input-format
branch
from
ef961d9 to
0a32a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The numericality validation in rails cannot handle prices in non-float based amounts (Ie. 100,00 EUR).
Using
Spree::LocalizedNumberto convert the amount before validation.Checklist: