Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API docs deprecation warnings consistent #4397

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented Jun 1, 2022

On efe4bec, 7c49645 & 3dcc3fa we added deprecation notices to the API documentation.

However, in 6b8004b, a better way, with actual links to the recommended routes, was used.

We update the formers to use actual links and a message format consistent with the latter.

See #4387 (comment) for details.

On efe4bec,
7c49645 &
3dcc3fa we added deprecation notices to
the API documentation.

However, in 6b8004b, a better way, with
actual links to the recommended routes, was used.

We update the formers to use actual links and a message format
consistent with the latter.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waiting-for-dev waiting-for-dev merged commit 4cc1d5a into solidusio:master Jun 2, 2022
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/add_deprecation_links branch June 2, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants