[v3.0] Only install ActiveStorage adapter on supported Rails versions #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only support the ActiveStorage adapter for Rails >= 6.1, but we install it for any supported Rails versions by default. If generating a dummy test app for an extension this leads to failing test runs, because Solidus quits oif the Rails version is not Rails 6.1 if using the ActiveStorage adapter. Solving by installing the ActiveStorage adapter only if the Rails version is >= 6.1.
jarednorman
approved these changes
Jun 2, 2022
waiting-for-dev
approved these changes
Jun 3, 2022
tvdeyen
deleted the
v3.0-do-not-install-active-storage-on-unsupported-rails-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We only support the ActiveStorage adapter for Rails >= 6.1,
but we install it for any supported Rails versions by default.
If generating a dummy test app for an extension this leads to
failing test runs, because Solidus quits oif the Rails version
is not Rails 6.1 if using the ActiveStorage adapter.
Solving by installing the ActiveStorage adapter only if the Rails
version is >= 6.1.
Checklist: