Remove N+1 from admin users #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2022
jarednorman
approved these changes
Jun 14, 2022
|
Hey @tvdeyen, could you rebase from master so that CI is green? 🙂 |
The has_many relation is called :orders, not :spree_orders
We preload users orders, but call count in the template. This will always query the database. Using none? uses the preloaded collection instead.
tvdeyen
force-pushed
the
remove-n1-from-admin-users
branch
from
ef0d3fa to
aa45abd
Compare
Done |
waiting-for-dev
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First fixing the preloading by using the correct relation name and then remove an explicit query by using a enumerable method to check if a user has orders in the admin users table.
Checklist: