Add display shipment total before tax #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it's easier to follow any changes.
There was no spec for this method.
This method is akin to Spree::Order#item_total_before_tax. If we have that method, we should have this one, too.
`item_total_before_tax`, `shipment_total_before_tax`, and `item_total_excluding_vat` are obviously methods that return a financial amount, so they should also be formattable money methods.
kennyadsl
approved these changes
Jun 14, 2022
| money_methods :outstanding_balance, :item_total, :adjustment_total, | ||
| :included_tax_total, :additional_tax_total, :tax_total, | ||
| :shipment_total, :total, :order_total_after_store_credit, :total_available_store_credit | ||
| money_methods( |
jarednorman
approved these changes
Jun 14, 2022
waiting-for-dev
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a few
money_methodsto theSpree::Ordermodel. I expected these to be there, and they weren't, so I guess it's in everyone's best interest to add them.Checklist: