Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect validation message for missing store credit category #4481

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Fix incorrect validation message for missing store credit category #4481

merged 1 commit into from
Aug 3, 2022

Conversation

johnpitchko
Copy link
Contributor

@johnpitchko johnpitchko commented Jul 31, 2022

Summary

Fix for #4468. Corrected text in en.yml. Note this is branched off PR #4481, but can rebase of master if you want to merge this one before that one.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the readme to account for my changes.

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if you don't mind rebasing out the extra commit from your other PR.

@gsmendoza
Copy link
Contributor

@gsmendoza
Copy link
Contributor

Hi @johnpitchko ! @waiting-for-dev and I weren't able to reproduce #4479. Like what @jarednorman said, can you remove the Fix bad MySQL package in Dockerfile commit from this PR? We'll need to investigate that separately. Thanks!

@waiting-for-dev
Copy link
Contributor

Thanks, @johnpitchko. Yeah, we should merge it once the extra commit is removed.

@johnpitchko
Copy link
Contributor Author

johnpitchko commented Aug 2, 2022

Thanks for your patience @jarednorman @gsmendoza @waiting-for-dev - was out of town for a few days. I dropped the commit so this should be ready now.

@waiting-for-dev waiting-for-dev merged commit 3962059 into solidusio:master Aug 3, 2022
@waiting-for-dev
Copy link
Contributor

Thanks, @johnpitchko!

@johnpitchko johnpitchko deleted the fix-incorrect-validation-message-for-missing-store-credit-category-id branch August 11, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants