Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include discarded prices in delete_prices_with_nil_amount task #4495

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Include discarded prices in delete_prices_with_nil_amount task #4495

merged 1 commit into from
Aug 9, 2022

Conversation

spaghetticode
Copy link
Member

Summary

The task delete_prices_with_nil_amount is currently removing only non-discarded prices. We should remove discarded prices as well, otherwise the migration path from https://github.com/solidusio/solidus/blob/master/CHANGELOG.md#solidus-310-v31-2021-09-10
may fail.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.

@spaghetticode
Include discarded prices in delete_prices_with_nil_amount task
5846225 
The task is currently removing only non-discarded prices. We should
remove discarded prices as well, otherwise the migration path from
https://github.com/solidusio/solidus/blob/master/CHANGELOG.md#solidus-310-v31-2021-09-10
may fail.
@spaghetticode spaghetticode added the type:bug Error, flaw or fault label Aug 8, 2022
@spaghetticode spaghetticode self-assigned this Aug 8, 2022
waiting-for-dev
waiting-for-dev approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @spaghetticode ❤️

kennyadsl
kennyadsl approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks Andrea!

@waiting-for-dev waiting-for-dev merged commit d169360 into solidusio:master Aug 9, 2022
@waiting-for-dev waiting-for-dev deleted the spaghetticode/delete-discarded-prices branch August 9, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees

@spaghetticode spaghetticode

Labels
type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spaghetticode @waiting-for-dev @kennyadsl @jarednorman