Run auth generator when starter frontend installs the gem #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the installation of solidus_auth_devise is performed by the installation of solidus_starter_frontend, we also need to run solidus_auth_devise' install generator. This responsibility needs to be eventually moved to the solidus_starter_frontend repository.
aldesantis
approved these changes
Aug 16, 2022
|
@waiting-for-dev thanks for all the hard work on this! ❤️ |
waiting-for-dev
deleted the
waiting-for-dev/fix_installer_no_auth_starter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the installation of solidus_auth_devise is performed by the
installation of solidus_starter_frontend, we also need to run
solidus_auth_devise' install generator. This responsibility needs to be
eventually moved to the solidus_starter_frontend repository.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the readme to account for my changes.