Add flexible with_adjustable_action trait to Promotion factory #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
kennyadsl
approved these changes
Oct 20, 2022
RyanofWoods
force-pushed
the
ryanofwoods/make-promotion-factory-with-line-item-adjustment-trait-more-flexible
branch
from
ad9c0fa to
0238a3b
Compare
Currently, we do not have a factory for Promotion::Actions and the existing adjustment traits are not flexible. This trait will be useful, for more flexiblity when testing non out-of-the-box Promotion Actions and different calculators.
Noteably, keep existing transient arguments to not cause breaking specs for stores. Also, by using the new with_adjustable_action trait, they automatically become more flexible due to its transient arguments.
RyanofWoods
force-pushed
the
ryanofwoods/make-promotion-factory-with-line-item-adjustment-trait-more-flexible
branch
from
0238a3b to
0b81b52
Compare
Codecov Report
@@ Coverage Diff @@
## master #4682 +/- ##
=======================================
Coverage 86.10% 86.11%
=======================================
Files 576 576
Lines 14627 14634 +7
=======================================
+ Hits 12595 12602 +7
Misses 2032 2032
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RyanofWoods
commented
Oct 21, 2022
RyanofWoods
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, we do not have a factory for Promotion Actions, and so this trait is used instead. Add more flexibility on the action and calculator class used is useful for when making new Promotion Actions.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):- [ ] I have added automated tests to cover my changes.- [ ] I have attached screenshots to demo visual changes.- [ ] I have opened a PR to update the guides.- [ ] I have updated the readme to account for my changes.