Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.2 backport] Ensure puma 6 is not used in development #4692

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

elia
Copy link
Member

@elia elia commented Oct 24, 2022

Summary

Puma 6 has a number of breaking changes and as of now the most recent version of rails is generating a gemfile requiring puma to be 5.

Backport of #4676.

cc @mamhoff

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the readme to account for my changes.

Puma 6 has a number of breaking changes and as of now the most recent
version of rails is generating a gemfile requiring puma to be 5.
@elia elia marked this pull request as ready for review October 24, 2022 11:26
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@waiting-for-dev waiting-for-dev merged commit 65f961e into solidusio:v3.2 Oct 24, 2022
@waiting-for-dev waiting-for-dev deleted the elia/3-2-puma-6 branch October 24, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants