Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typo from warning about solidus migration check #4704

Conversation

jacobherrington
Copy link
Contributor

Summary

Fixing a typo that I noticed while trying to recreate a bug!

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

- [ ] I have added automated tests to cover my changes.
- [ ] I have attached screenshots to demo visual changes.
- [ ] I have opened a PR to update the guides.
- [ ] I have updated the readme to account for my changes.

@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #4704 (ff7c6ae) into master (1fe96cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4704   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files         577      577           
  Lines       14640    14640           
=======================================
  Hits        12608    12608           
  Misses       2032     2032           
Impacted Files Coverage Δ
core/lib/spree/migrations.rb 83.78% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waiting-for-dev
Copy link
Contributor

Thanks, @jacobherrington!

@waiting-for-dev waiting-for-dev merged commit 54a16e5 into solidusio:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants