Revert jQuery changes to xhr var in image upload #4707
Conversation
github-actions
bot
added
the
changelog:solidus_backend
cpfergus1
force-pushed
the
cpfergus1/fix-broken-image-upload-js
branch
2 times, most recently
from
1166cdf to
b2c5ba7
Compare
cpfergus1
changed the title
The was changed by mistake to `$.ajaxSetup.xhr()` and broke the image upload drop field. The error was missed because there were not any existing tests for the image drop field so the script was not being properly tested. Although `$.ajaxSetup().xhr()` could work in this situation, it will be fully reverted to original due to inability to find source of deprecation cited in commit that changed this function.
cpfergus1
force-pushed
the
cpfergus1/fix-broken-image-upload-js
branch
from
b2c5ba7 to
58fcaae
Compare
Codecov Report
@@ Coverage Diff @@
## master #4707 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 577 577
Lines 14640 14640
=======================================
Hits 12608 12608
Misses 2032 2032 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you! |
|
@waiting-for-dev we need a backport here. what about using our brand-new label feature? 😎 |
|
@kennyadsl, I also thought that. But, as far as I can see, the reverted commit is only in master. It was merged on September 13th, while Solidus v3.2 was released on August 18th 🤔 |
|
@waiting-for-dev please look at the history here. It seems that the same commit has been done prior to bumping to 3.2.3. I think it doesn't show in the list of versions where the commit exists because it has been backported. |
|
Oh, all right, it makes sense 🙂 |
|
Bot 🤖 working for v3.2 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
[v3.2] Merge pull request #4707 from cpfergus1/cpfergus1/fix-broken-image-upload-js
Summary
This PR reverts 6ae4717 from #4625. A set of parenthesis was missing in the call and should have been
$.ajaxSetup().xhr(). An additional test was created covering the drop window for images and the change to$.ajaxSetup().xhr()was fully reverted because the reason cited for the change could not be verified (I cannot find a source that states the method is deprecated).Resolves #4706
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):I have attached screenshots to demo visual changes.I have opened a PR to update the guides.I have updated the readme to account for my changes.