Remove unused columns from spree_promotion_rules #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
drop-unused-promotion-rule-product-group
branch
from
8c2fbe0 to
a1316e5
Compare
waiting-for-dev
added
the
release:major
Codecov Report
@@ Coverage Diff @@
## master #4881 +/- ##
==========================================
+ Coverage 85.88% 86.25% +0.36%
==========================================
Files 533 577 +44
Lines 13225 14678 +1453
==========================================
+ Hits 11358 12660 +1302
- Misses 1867 2018 +151 see 79 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
waiting-for-dev
approved these changes
Jan 27, 2023
spaghetticode
approved these changes
Jan 27, 2023
adammathys
approved these changes
Jan 27, 2023
product_group_id refers to something that was removed from Spree in version 1.1 (see https://github.com/spree-contrib/spree_product_groups). code refers to nothing.
mamhoff
force-pushed
the
drop-unused-promotion-rule-product-group
branch
from
a1316e5 to
2af41c2
Compare
|
Rebased from |
kennyadsl
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
product_group_idrefers to something that was removed from Spree in version 1.1 (see https://github.com/spree-contrib/spree_product_groups).coderefers to nothing.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):I have added automated tests to cover my changes.I have attached screenshots to demo visual changes.I have opened a PR to update the guides.I have updated the README to account for my changes.