[v3.1] Allow storing static preferences using string class names #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make unnecessary to wrap these definitions under `.to_prepare` blocks. Additionally the error message for unexpected keys has improved and now lists both all the unexpected keys along with the expected keys, mentioning the name associated to the definition. Backports solidusio#4858 to v3.1
github-actions
bot
added
the
changelog:solidus_core
waiting-for-dev
deleted the
waiting-for-dev/static_preferences_string_v31
branch
waiting-for-dev
added a commit
to solidusio/solidus_stripe
that referenced
this pull request
Mar 7, 2023
There's no longer the need to call `.to_prepare`, as the issue has been fixed upstream: - v3.3: solidusio/solidus#4858 - v3.2: solidusio/solidus#4939 - v3.1: solidusio/solidus#4967
Merged
3 tasks
waiting-for-dev
added a commit
to solidusio/solidus_stripe
that referenced
this pull request
Mar 7, 2023
There's no longer the need to call `.to_prepare`, as the issue has been fixed upstream: - v3.3: solidusio/solidus#4858 - v3.2: solidusio/solidus#4939 - v3.1: solidusio/solidus#4967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backports #4858 to v3.1
This will make unnecessary to wrap these definitions under
.to_prepareblocks.
Additionally the error message for unexpected keys has improved and
now lists both all the unexpected keys along with the expected keys,
mentioning the name associated to the definition.
References solidusio/solidus_stripe#170
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: